Gosub_scene error

Game Development ChoiceScript Help
1

Another day, another gremlin :slight_smile:

OK, when I manually play through my story (which is starting to become a pretty major undertaking!) it plays through just fine, no errors pop up at all success! But, when I run Randomtest in CSIDE it comes up with an error. The error is:

RANDOMTEST FAILED: Error: subroutines line 172: invalid return; weā€™ve already returned from the last gosub

Two things strike me as odd about this. First off (after going through the rather lengthy subroutine) there are no duplicate calls. Second, the path the Randomtest took never called the subroutine. Does anyone have any ideas what could be causing this error? Iā€™m including the section of code that includes the line it refrences (not the whole subroutine though, did I mention itā€™s pretty big?)

*else
    *if (race = "elf")
        *if (gender = "Male")
            *set greeting "forest lord"
            *set farewell "milord"
            *return
        *elseif (gender = "Female")
            *set greeting "forest lady"
            *set farewell "milady"
            *return
        *else
            *set greeting "deepwood friend"
            *set farewell "respected friend"
            *return
    *elseif (race = "trylle")
        *set greeting "noble one"
        *set farewell "dear friend"
        *return
    *elseif (race = "halfling")
        *set greeting "fairkin"
        *set farewell "close cousin"
        *return
    *elseif (race = "crossborn")
        *if (gender = "Male")
            *set greeting "brother"
            *set farewell "bonded brother"
            *return
        *elseif (gender = "Female")
            *set greeting "sister"
            *set greeting "bonded sister"
            *return
        *else
            *set greeting "sibling"
            *set farewell "bonded one"
            *return
    *else
        *set greeting "nothinglost"
        *set farewell "stranger"
        *return

Any suggestions would be appreciated!

Lessa

2

if the randomtest (does quicktest call it) doesnā€™t call a subroutine it might easily be an indent error.

two: how often is this bit called in the scene itā€™s in? assuming itā€™s a gosub and not a gosubscene

1 Like
3

Quicktest doesnā€™t seem to call it, I have a harder time decoding what Quicktest is doing.

I meant that the path the Randomtest is taking through the story never takes an option that calls that subroutine. Iā€™m only having Randomtest run through one iteration right now. It gets to the end of the run and pops up that error message after itā€™s finished running through the story.

In that scene (the subroutine is called via gosub_scene) it gets called a total of three possible times, one per merchant. Whether itā€™s called at all or not depends on whether or not you go to a merchant in that scene, itā€™s possible to move on to the next scene without ever going to a merchant. Iā€™m using it as a subroutine because I am planning to have other merchants as you travel through the land - and the story :slight_smile:

4

mhnnnā€¦ if quicktest doesnā€™t call it (quicktest just checks if indents etc are correct) that might mean an indent error.

also a possibility:
do you have the subsceneā€™s file listed on your scenelist?

if yes: where and if at the end check if your last file ends on *ending

if no: are you going to call the subscene only in one major scene or sometime else later on too?

edit:
also you are setting ā€˜greetingā€™ twice for female crossborns

5

I do have the subscene file on my scenelist. I make sure to keep that updated as I add new scenes. Currently the subscene file is about in the center of my scenelist.

I made is a subroutine in a separate scene file because Iā€™m planning to call it in other scenes. For that reason I also have the variables that itā€™s checking as permanent in the setup file instead of using temp variables.

I just tried adding *ending where the story ends right now, and when I ran Randomtest it didnā€™t give me any errors. Thank you for suggesting that, I wouldnā€™t have thought of it!

Thank you for catching that I was setting ā€œgreetingā€ twice, I canā€™t believe I missed that :smiley:

6

Ah, thereā€™s the error:

The games will call scenes in the order of the scenelist, meaning if you have a subscene in there in the middle it will call the subscene without anywhere to return to.
e.g.

*scene_list
   scene1
   scene2
   subscene
   scene3

or similar it will NOT go from 2 to 3.

Also, you donā€™t need subscenes in the scenefile, as long as they are in the folder
try removing it from the scenelist and check then

1 Like
7

Oh thatā€™s wonderful information to know, thank you so much!

8

also, question:
you are only setting greetings and farewells here.
How and when do they change?
cause, albeit you got a lot, you could do the same with multireplace or setting it at the race/gender choice maybe, depending on how this is meant to play out

9

The greetings and farewells (at this point) are going to change based on the race of the shopkeeper and the race chosen for the PC. So, if the shopkeeper is a human, how they greet and say goodbye to you is based on which race you choose at the beginning, Those will be different is the shopkeeper was another elf or a dwarf etc. Can you point me in the direction of how to use multireplace? Iā€™m still learning so much about writing in CS!

10

basically multireplace works like this:

you have a variable, be it true/false, numeral or a text.

you call it by using @{(var) text for the variable| other text} continued text.

the | separates the various bits of text to use.

for example

True/false:
He @{atesoup ate| didn't eat} the soup.

True/false will need two bits of text. One for the variable used being true, one for it being false.

This here will print as either ā€˜He ate the soupā€™ or ā€˜He didnā€™t eat the soupā€™ depending on whether or not the ā€˜atesoupā€™ variable is true or false.

numeral variable work like this

@{var 1| 2| 3| 4} further text.

OR

@{(var =3} text for 3| text for all others}

string variables are similar:

@{(var ="variable") text for that specific variable| other text} more text

you can also combine variables

@{((var ="blue") or (var2)) text for that combo| other text}

You can however NOT nest multireplace in multireplace, so there you should use *if trees

*if (var ="first")
   @{var2 1| 2| 3} text
*if (var ="second")
   @{var2 4| 5| 6} text

And for formatting

Word'@{plur re|s}

will print as
Wordā€™re / Wordā€™s (good for pronouns that use plural verbs)

word @{plur are| is}

will print as
word are/ word is

hope that helps

11

That helps a lot, thank you so much!

1 Like
12

welcome :3

good luck