I am in favor of all of it. Hard choices, losing a love interest, endings that can never be perfect. I am 100% in for them all.
The one thing that you need to be careful with is the player sacrifice ending. If the story is good, and engaging by the time I reach the ending the line between me and my character is well blurred. So much so, that experiencing part of the story after my character is dead is going to feel weird, and any emotional impact of things that happen after “I’m” dead will be lessened.
The game that dealt with my character’s death the best just ended, black screen, roll credits when she died, but even that wasn’t perfect. It’s a tricky problem, and I don’t honestly have a good solution.